Skip to content

chore: downgrade grpc plugin version#4809

Merged
JoeWang1127 merged 4 commits intomainfrom
chore/downgrade-grpc-plugin
Mar 25, 2026
Merged

chore: downgrade grpc plugin version#4809
JoeWang1127 merged 4 commits intomainfrom
chore/downgrade-grpc-plugin

Conversation

@JoeWang1127
Copy link
Copy Markdown
Contributor

@JoeWang1127 JoeWang1127 commented Mar 24, 2026

Downgrade the grpc plugin version to 1.3.0, matches the version in legacylibrarian Dockerfile.

We can avoid downloading a different version of dependency when running librarian generate.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.41%. Comparing base (e5b3a13) to head (93c3e8a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4809   +/-   ##
=======================================
  Coverage   81.41%   81.41%           
=======================================
  Files         130      130           
  Lines       10860    10860           
=======================================
  Hits         8842     8842           
  Misses       1383     1383           
  Partials      635      635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request downgrades the google.golang.org/grpc/cmd/protoc-gen-go-grpc dependency from v1.6.0 to v1.3.0 and updates the go.sum file. The review feedback indicates that this dependency downgrade lacks a necessary explanation, which is crucial for future maintainability and aligns with the repository's style guide. It is suggested to add a code comment to clarify the reason for the downgrade, specifically to avoid issues with newer versions requiring protoc-gen-go-grpc to be in the system PATH.

Comment thread go.mod
@JoeWang1127 JoeWang1127 marked this pull request as ready for review March 24, 2026 21:18
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner March 24, 2026 21:18
Comment thread go.mod Outdated
@julieqiu
Copy link
Copy Markdown
Member

We should add a post-submit check which fails if the version of google.golang.org/grpc/cmd/protoc-gen-go-grpc changes and something breaks, similar to what we have for google-cloud-rust.

@JoeWang1127
Copy link
Copy Markdown
Contributor Author

We should add a post-submit check which fails if the version of google.golang.org/grpc/cmd/protoc-gen-go-grpc changes and something breaks, similar to what we have for google-cloud-rust.

Filed #4811

@JoeWang1127 JoeWang1127 requested a review from julieqiu March 25, 2026 01:11
@JoeWang1127 JoeWang1127 merged commit 6064cf7 into main Mar 25, 2026
36 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/downgrade-grpc-plugin branch March 25, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants