Open
Conversation
product-auto-label
bot
added
size: l
nimf
reviewed
Feb 27, 2026
| Meter meter = openTelemetry.getMeter(METER_NAME); | ||
| this.compatibleGauge = | ||
| meter | ||
| .gaugeBuilder(DIRECT_ACCESS_COMPATIBLE_NAME) |
There was a problem hiding this comment.
AFAIK, gauges cannot be aggregated. Have you tried running a few clients and run a query to graph the number of eligible clients? Also, how can we know the number of not eligible clients if this reports 0?
Maybe worth converting to UpDownCounter with a label signifying eligibility.
nimf
reviewed
Feb 27, 2026
| // Wrap the channel with our custom ALTS interceptor | ||
| Channel interceptedChannel = ClientInterceptors.intercept(channel, altsInterceptor); | ||
|
|
||
| ManagedChannel wrappedManagedChannel = |
There was a problem hiding this comment.
Just FYI: welp, this is awkward -- ChannelPrimer should operate on Channel and not ManagedChannel, but I'm not sure if we can change this now. If we could change it, we wouldn't need this wrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.