feat(spanner): [WIP] support data client#4701
Closed
olavloite wants to merge 13 commits intogoogleapis:mainfrom
Closed
feat(spanner): [WIP] support data client#4701olavloite wants to merge 13 commits intogoogleapis:mainfrom
olavloite wants to merge 13 commits intogoogleapis:mainfrom
Conversation
Add a data-plane client for Spanner.
Contributor
|
/gcbrun |
coryan
requested changes
Feb 16, 2026
Contributor
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Thanks for the PR! I think you can skip the grpc-mock subdirectory in the first PR and things will be easier to review and merge.
Also filed googleapis/librarian#4073 because the grpc-mock thing is tedious. Do not worry, I believe we should continue to make progress with this PR (maybe split in smaller PRs) and leave the sidekick automation for later.
Contributor
|
/gcbrun |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4701 +/- ##
==========================================
- Coverage 95.02% 89.93% -5.09%
==========================================
Files 204 215 +11
Lines 7877 8320 +443
==========================================
- Hits 7485 7483 -2
- Misses 392 837 +445 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
olavloite
force-pushed
the
spanner-client
branch
from
aae7512 to
4efe012
Compare
olavloite
force-pushed
the
spanner-client
branch
from
58de901 to
671519a
Compare
olavloite
force-pushed
the
spanner-client
branch
from
eebfef2 to
16463e2
Compare
Contributor
Author
|
No longer relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WORK IN PROGRESS]
Add a data-plane client for Spanner.
Depends on googleapis/librarian#4072