feat: regenerate automl using generator v1.32.0 #17154
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request drops support for Python 3.9 across the google-cloud-automl package, updating the minimum requirement to Python 3.10 and bumping several dependency lower bounds, including google-api-core and grpcio. Significant updates were made to async client samples to ensure proper usage of await, and legacy compatibility code for older Python versions was removed. Feedback suggests aligning the google-auth version with the PR's stated objectives and retaining the -W flag in the documentation build to ensure CI catches warnings as errors.
| # For example, if setup.py has "google-cloud-foo >= 1.14.0, < 2.0.0", | ||
| # then this file should have google-cloud-foo==1.14.0 | ||
| google-api-core==2.17.1 | ||
| google-auth==2.14.1 |
There was a problem hiding this comment.
The pull request description states that google-auth should be bumped to >=2.26.1 to prevent dependency resolution issues. However, it is pinned to 2.14.1 here, and the requirement in setup.py (line 45) also remains at 2.14.1. Please update both files to use 2.26.1 as the lower bound to align with the PR's stated objective.
google-auth==2.26.1
| shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True) | ||
| session.run( | ||
| "sphinx-build", | ||
| "-W", # warnings as errors |
There was a problem hiding this comment.
Removing the -W flag from sphinx-build prevents documentation warnings from being treated as errors. This can lead to a decrease in documentation quality as new warnings may go unnoticed. It is recommended to keep this flag to ensure all documentation issues are caught and addressed during CI.
References
- Changes to shared configurations, like build flags in noxfile.py, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal.
1 participant
Bump google-auth to >=2.26.1 to prevent dependency resolution issue.
Partially corrects #17153 🦕