Skip to content

fix(storage): fix test_mrd_concurrent_download_cancellation #17151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nidhiii-27 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Draft

fix(storage): fix test_mrd_concurrent_download_cancellation #17151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/google-cloud-storage/tests/system/test_zonal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,7 @@ def test_mrd_concurrent_download_cancellation(
Tests that downloading gracefully manages memory and internal references
when tasks are canceled during active multiplexing, without breaking remaining downloads.
"""
object_size = 5 * 1024 * 1024 # 5MB
object_size = 20 * 1024 * 1024 # 20MB
object_name = f"test_mrd_cancel-{uuid.uuid4()}"

async def _run():
Expand All @@ -844,7 +844,7 @@ async def _run():
grpc_client_direct, _ZONAL_BUCKET, object_name
) as mrd:
tasks = []
num_chunks = 100
num_chunks = 40
chunk_size = object_size // num_chunks
buffers = [BytesIO() for _ in range(num_chunks)]

Expand All @@ -856,8 +856,8 @@ async def _run():
)
)

# Let the loop start sending Bidi requests
await asyncio.sleep(0.01)
# Yield control to event loop so tasks send Bidi requests, but do not wait for server responses
await asyncio.sleep(0)

# Cancel a subset of evenly distributed tasks
for i in range(0, num_chunks, 2):
Expand Down
Loading