Skip to content

fix: allow multi-part dataset IDs to support BigLake tables#17137

Merged
shuoweil merged 6 commits into
mainfrom
b512823729-bq-string-references
May 14, 2026
Merged

fix: allow multi-part dataset IDs to support BigLake tables#17137
shuoweil merged 6 commits into
mainfrom
b512823729-bq-string-references

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented May 14, 2026

Relaxes DatasetReference.from_string and TableReference.from_string validation.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/512823729 🦕

Relaxes DatasetReference.from_string and TableReference.from_string
validation.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new internal module _string_references.py to centralize the parsing of dataset and table ID strings into REST resource representations, refactoring DatasetReference.from_string and TableReference.from_string to use these shared utilities. Feedback focuses on ensuring Python version compatibility for type unions, correcting PEP 8 indentation violations, programmatically sorting returned dictionaries per repository rules, and refining the logic for multi-part dataset IDs.

Comment thread packages/google-cloud-bigquery/google/cloud/bigquery/_string_references.py Outdated
Comment thread packages/google-cloud-bigquery/google/cloud/bigquery/_string_references.py Outdated
Comment thread packages/google-cloud-bigquery/google/cloud/bigquery/_string_references.py Outdated
Comment thread packages/google-cloud-bigquery/google/cloud/bigquery/_string_references.py Outdated
@tswast tswast marked this pull request as ready for review May 14, 2026 19:12
@tswast tswast requested review from a team as code owners May 14, 2026 19:12
@tswast tswast requested review from shuoweil and removed request for a team May 14, 2026 19:12
@shuoweil shuoweil merged commit f93911c into main May 14, 2026
31 checks passed
@shuoweil shuoweil deleted the b512823729-bq-string-references branch May 14, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants