Skip to content

Add missing usedBy field to Certificate type in certificate_manager_v1#17135

Draft
mervin008 wants to merge 1 commit into
googleapis:mainfrom
mervin008:feat-certificatemanager-add-certificate-used-by-field
Draft

Add missing usedBy field to Certificate type in certificate_manager_v1#17135
mervin008 wants to merge 1 commit into
googleapis:mainfrom
mervin008:feat-certificatemanager-add-certificate-used-by-field

Conversation

@mervin008
Copy link
Copy Markdown

@mervin008 mervin008 commented May 14, 2026

The REST API Certificate resource exposes a usedBy[] field (field number 10) of type UsedBy, but the Python client's Certificate type does not include it.

Changes

  • Added Certificate.UsedBy inner message class with a name string field (field number 1)
  • Added Certificate.used_by repeated field (field number 10)
  • Updated Certificate class docstring to document the new field
  • Fixed ip_configs field formatting in CertificateMap.GclbTarget (minor syntax fix)

Checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #17134 🦕

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 14, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mervin008 mervin008 changed the title Add used_by field and UsedBy message type to Certificate resource Add missing usedBy field to Certificate type in certificate_manager_v1 May 14, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Certificate message in the Certificate Manager library by adding a used_by field, which tracks resources utilizing the certificate. The feedback suggests reordering the newly added field to maintain numerical consistency with existing fields and removing excessive blank lines between class definitions to adhere to PEP 8 standards.

@mervin008 mervin008 marked this pull request as ready for review May 14, 2026 14:56
@mervin008 mervin008 requested a review from a team as a code owner May 14, 2026 14:56
@mervin008 mervin008 marked this pull request as draft May 14, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Certificate type missing usedBy field in certificate_manager_v1

1 participant