Skip to content

feat: regenerate google-cloud-dialogflow#17129

Merged
jskeet merged 2 commits into
googleapis:mainfrom
jskeet:unskip-dialogflow
May 14, 2026
Merged

feat: regenerate google-cloud-dialogflow#17129
jskeet merged 2 commits into
googleapis:mainfrom
jskeet:unskip-dialogflow

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented May 14, 2026

Updates the Dialogflow API, which was previously blocked on a resource
name conflict.

This Pull Request also drops support for Python <=3.9 in generated packages.
This is part of our ongoing effort to modernize the Cloud Python SDK
libraries and remove support for End-of-Life (EOL) Python versions.

  • Removed Python <=3.9 from testing, configuration, and constraints files.
  • Resolved dependency conflicts arising from dropping Python <=3.9 support.
  • Cleaned up obsolete code related to Python <=3.9 support.
  • Updated select copyright dates
  • Updated some autogenerated headings
  • Updated some tests to resolve issues discovered during this migration.

@jskeet jskeet requested a review from parthea May 14, 2026 09:20
@jskeet jskeet requested review from a team as code owners May 14, 2026 09:20
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Google Cloud Dialogflow library to include support for CES tools and apps, adds comprehensive debugging information for knowledge-based features, and updates sample code to use modern asynchronous patterns. It also includes maintenance updates such as documentation link corrections, copyright year increments to 2026, and updated Python version compatibility warnings. Review feedback identified several typographical errors in the docstrings of the newly introduced Participant and KnowledgeAssist debug types, which should be corrected for clarity.

Dialogflow CX agent have been configured to return partial
responses.
output_multiple_utterances (bool):
Optional. If multiple uttereances are
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the docstring: "uttereances" should be "utterances".

Suggested change
Optional. If multiple uttereances are
Optional. If multiple utterances are

indicates data serving status or answer quality
degradation.
knowledge_assist_behavior (google.cloud.dialogflow_v2.types.KnowledgeAssistDebugInfo.KnowledgeAssistBehavior):
Configured behaviors for Knowedge Assist.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the docstring: "Knowedge" should be "Knowledge".

Suggested change
Configured behaviors for Knowedge Assist.
Configured behaviors for Knowledge Assist.

Query generation is blocked due to out of
quota.
QUERY_GENERATION_FAILED (2):
Call to Knowedge Assist query generation
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the docstring: "Knowedge" should be "Knowledge".

Suggested change
Call to Knowedge Assist query generation
Call to Knowledge Assist query generation

queries generated in the previous turns.
QUERY_GENERATION_RAI_FAILED (4):
Knowedge Assist generated query is blocked by
RAI (Responsible AI).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the docstring: "Knowedge" should be "Knowledge".

Suggested change
RAI (Responsible AI).
Knowledge Assist generated query is blocked by

QUERY_CATEGORIZATION_FAILED = 3

class KnowledgeAssistBehavior(proto.Message):
r"""Configured behaviors for Knowedge Assist.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the docstring: "Knowedge" should be "Knowledge".

Suggested change
r"""Configured behaviors for Knowedge Assist.
r"""Configured behaviors for Knowledge Assist.

deliver.
disable_sync_delivery (bool):
Whether customers configured to disable the
synchronous delivery of Knowedge Assist
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the docstring: "Knowedge" should be "Knowledge".

Suggested change
synchronous delivery of Knowedge Assist
synchronous delivery of Knowledge Assist

jskeet added 2 commits May 14, 2026 09:34
Adds new generator options to fix the previous issues.

Fixes googleapis/librarian#5333
Updates the Dialogflow API, which was previously blocked on a resource
name conflict.

This Pull Request also drops support for Python <=3.9 in generated packages.
This is part of our ongoing effort to modernize the Cloud Python SDK
libraries and remove support for End-of-Life (EOL) Python versions.

- Removed Python <=3.9 from testing, configuration, and constraints files.
- Resolved dependency conflicts arising from dropping Python <=3.9 support.
- Cleaned up obsolete code related to Python <=3.9 support.
- Updated select copyright dates
- Updated some autogenerated headings
- Updated some tests to resolve issues discovered during this migration.
@jskeet jskeet force-pushed the unskip-dialogflow branch from 9b1ebc0 to 7eaec03 Compare May 14, 2026 09:34
@jskeet jskeet merged commit b6bb63e into googleapis:main May 14, 2026
31 checks passed
@jskeet jskeet deleted the unskip-dialogflow branch May 14, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants