feat: regenerate remaining packages#17078
Conversation
This Pull Request drops support for Python <=3.9 in generated packages. This is part of our ongoing effort to modernize the Cloud Python SDK libraries and remove support for End-of-Life (EOL) Python versions. - Removed Python <=3.9 from testing, configuration, and constraints files. - Resolved dependency conflicts arising from dropping Python <=3.9 support. - Cleaned up obsolete code related to Python <=3.9 support. - Updated select copyright dates - Updated some autogenerated headings - Updated some tests to resolve issues discovered during this migration.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates copyright years to 2026, bumps minimum Python version requirements to 3.10, updates dependencies (google-api-core, grpcio), and modifies test assertions to use sorted parameter lists. I have identified an issue regarding the removal of the '-W' flag in the documentation build configuration, which should be applied consistently across all packages rather than in a single package.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/google-ads-datamanager/noxfile.py (391)
The -W flag (warnings as errors) has been removed from the sphinx-build command. This flag is important for maintaining documentation quality. According to repository guidelines, changes to shared configurations should be applied consistently across all packages in a universal change rather than piecemeal. Please restore this flag to maintain consistency.
"sphinx-build",
"-W", # warnings as errors
References
- Changes to shared configurations, like mypy or build flags, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
This Pull Request drops support for Python <=3.9 in generated packages. This is part of our ongoing effort to modernize the Cloud Python SDK libraries and remove support for End-of-Life (EOL) Python versions. - Removed Python <=3.9 from testing, configuration, and constraints files. - Resolved dependency conflicts arising from dropping Python <=3.9 support. - Cleaned up obsolete code related to Python <=3.9 support. - Updated select copyright dates - Updated some autogenerated headings - Updated some tests to resolve issues discovered during this migration.
2 participants
This Pull Request drops support for Python <=3.9 in generated packages. This is part of our ongoing effort to modernize the Cloud Python SDK libraries and remove support for End-of-Life (EOL) Python versions.