Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/google-cloud-spanner/noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()

nox.options.sessions = [
"unit-3.9",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change appears to be part of a global infrastructure update (removal of Python 3.9). According to repository rules, changes to shared configurations should be applied consistently across all relevant packages in a single, universal pull request rather than piecemeal. When this change is consolidated, ensure that the project metadata (e.g., 'python_requires' in 'setup.py' or 'pyproject.toml') is updated to reflect the new minimum version. Additionally, since dropping support for a Python version is a breaking change, ensure a minor version bump is used instead of a patch bump to maintain the ability to provide patches for the previous version.

References
  1. Changes to shared configurations, like mypy flags, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
  2. When updating the minimum supported Python version in runtime checks (e.g., 'sys.version_info' checks), ensure that the project's metadata in 'setup.py' or 'pyproject.toml' is also updated to reflect the same minimum version in 'python_requires' and Trove classifiers.
  3. When a release introduces breaking changes in environment requirements, such as dropping support for specific Python versions or major dependency versions (e.g., protobuf), prefer a minor version bump over a patch version bump.

"unit-3.10",
"unit-3.11",
"unit-3.12",
Expand Down
Loading