chore: librarian generate pull request: 20260224T181837Z#15606
Closed
cloud-sdk-librarian-robot wants to merge 1 commit intomainfrom
Closed
chore: librarian generate pull request: 20260224T181837Z#15606cloud-sdk-librarian-robot wants to merge 1 commit intomainfrom
cloud-sdk-librarian-robot wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
Member
|
This was my confirmation about authentication. |
Contributor
Summary of ChangesHello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates significant updates across several Google Cloud client libraries, primarily enhancing the Google Ads Data Manager and Google Cloud Developer Connect services. It introduces a wide array of new resources, services, and functionalities for audience management, partner linking, marketing insights, and developer connection configurations. A minor feature enhancement was also applied to the Google Cloud Speech API, and documentation was refined for Google Cloud Database Center. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request, generated by the Librarian CLI, introduces a significant number of new features by adding several new services and types to the google-ads-datamanager package. The changes include new clients, documentation, and configuration for services like MarketingDataInsightsService, PartnerLinkService, and various user list license services. My review focuses on code generation quality and maintainability. I've identified a couple of minor issues: the __all__ list in one of the __init__.py files is not alphabetically sorted, and several new documentation files have incorrect underlining for titles. These are stylistic issues that should be addressed in the generator for better consistency and readability.
| @@ -0,0 +1,6 @@ | |||
| MarketingDataInsightsService | |||
| ---------------------------------------------- | |||
Contributor
There was a problem hiding this comment.
In reStructuredText, the underline for a section title should be the same length as the title text itself. The current underline is longer than the title 'MarketingDataInsightsService'.
Suggested change
| ---------------------------------------------- | |
| ---------------------------- |
| @@ -0,0 +1,10 @@ | |||
| PartnerLinkService | |||
| ------------------------------------ | |||
Contributor
There was a problem hiding this comment.
In reStructuredText, the underline for a section title should be the same length as the title text itself. The current underline is longer than the title 'PartnerLinkService'.
Suggested change
| ------------------------------------ | |
| ------------------ |
| @@ -0,0 +1,10 @@ | |||
| UserListDirectLicenseService | |||
| ---------------------------------------------- | |||
Contributor
There was a problem hiding this comment.
In reStructuredText, the underline for a section title should be the same length as the title text itself. The current underline is longer than the title 'UserListDirectLicenseService'.
Suggested change
| ---------------------------------------------- | |
| ---------------------------- |
| @@ -0,0 +1,10 @@ | |||
| UserListGlobalLicenseService | |||
| ---------------------------------------------- | |||
Contributor
There was a problem hiding this comment.
In reStructuredText, the underline for a section title should be the same length as the title text itself. The current underline is longer than the title 'UserListGlobalLicenseService'.
Suggested change
| ---------------------------------------------- | |
| ---------------------------- |
| @@ -0,0 +1,10 @@ | |||
| UserListService | |||
| --------------------------------- | |||
Contributor
There was a problem hiding this comment.
In reStructuredText, the underline for a section title should be the same length as the title text itself. The current underline is longer than the title 'UserListService'.
Suggested change
| --------------------------------- | |
| --------------- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: add
UserListGlobalLicenseCustomerInforesourcePiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
PartnerLinkServicefor creating and managing links between advertiser and data partner accountsPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
UserListresourcePiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
GOOGLE_AD_MANAGER_AUDIENCE_LINKto theAccountTypeenumPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add new
ErrorReasonvalues for licensing, user list operations, and permission checksPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: a comment for message
PairDatais changed to clarify it is only available to data partnersPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: changed
conversion_valuefield to be optional in messageEventPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
IngestUserIdDataStatustoIngestAudienceMembersStatusto report the status of user ID data ingestionPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: a comment for field
pair_datain messageAudienceMemberis changed to clarify it is only available to data partnersPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
UserListDirectLicenseServicefor creating and managing direct user list licensesPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
PartnerLinkresourcePiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
IngestPpidDataStatustoIngestAudienceMembersStatusto report the status of PPID data ingestionPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
RemovePpidDataStatustoRemoveAudienceMembersStatusto report the status of PPID data removalPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
AgeRangeandGenderenums to support demographic breakdown in marketing insightsPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
UserListGlobalLicenseresourcePiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
UserListDirectLicenseresourcePiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
RemoveUserIdDataStatustoRemoveAudienceMembersStatusto report the status of user ID data removalPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: add comments to resources and methods to clarify which are available only to data partners
PiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: a comment for enum
ErrorReasonis changed to clarify that it is subject to future additionsPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
UserListServicefor creating and managing user listsPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
UserListGlobalLicenseServicefor creating and managing global user list licensesPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
PpidDatatoAudienceMemberto support Publisher Provided ID (PPID) in audience member ingestionPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
UserIdDatatoAudienceMemberto support User ID in audience member ingestionPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
MarketingDataInsightsServicefor retrieving marketing data insights for a given user listPiperOrigin-RevId: 873059573
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@1e6955c6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
projectsis added to messagegoogle.cloud.developerconnect.v1.insights.InsightsConfigPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new enum value
GEMINI_CODE_ASSISTis added to enumgoogle.cloud.developerconnect.v1.GitHubConfig.GitHubAppPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add Cloud Run and App Hub Service runtimes to InsightsConfig
PiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.insights.Projectsis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.insights.AppHubServiceis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add HTTP Proxy base URI field
PiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
app_hub_serviceis added to messagegoogle.cloud.developerconnect.v1.insights.RuntimeConfigPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Corrected typos in comments for
google.cloud.developerconnect.v1.insights.InsightsConfigandgoogle.cloud.developerconnect.v1.insights.ArtifactConfigPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.FinishOAuthResponseis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add Deployment Events to Insights API (GetDeploymentEvent, ListDeploymentEvents)
PiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
secure_source_manager_instance_configis added to messagegoogle.cloud.developerconnect.v1.ConnectionPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.FinishOAuthRequestis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add Secure Source Manager and Generic HTTP Endpoint connection types
PiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.insights.GoogleCloudRunis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.insights.ListDeploymentEventsRequestis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
http_configis added to messagegoogle.cloud.developerconnect.v1.ConnectionPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Updated comment for
CreateGitRepositoryLinkRPC ingoogle.cloud.developerconnect.v1.DeveloperConnectPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.StartOAuthResponseis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.insights.ArtifactDeploymentis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.GenericHTTPEndpointConfigis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.insights.GetDeploymentEventRequestis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Updated comments to include regional secret patterns for SecretManager fields in
GitHubConfig,OAuthCredential,UserCredential,GitLabConfig,GitLabEnterpriseConfig,BitbucketDataCenterConfig, andBitbucketCloudConfigPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
http_proxy_base_uriis added to messagegoogle.cloud.developerconnect.v1.HTTPProxyConfigPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add Projects field to InsightsConfig for project tracking
PiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add Gemini Code Assist GitHub App type
PiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
organizationis added to messagegoogle.cloud.developerconnect.v1.GitHubEnterpriseConfigPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.insights.DeploymentEventis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.StartOAuthRequestis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
google_cloud_runis added to messagegoogle.cloud.developerconnect.v1.insights.RuntimeConfigPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add OAuth flow RPCs (StartOAuth, FinishOAuth)
PiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.SecureSourceManagerInstanceConfigis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
google.cloud.developerconnect.v1.insights.ListDeploymentEventsResponseis addedPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Updated description for
google.cloud.location.Locations.ListLocationsin YAMLPiperOrigin-RevId: 872542190
Library-IDs: google-cloud-developerconnect
Source-link: googleapis/googleapis@7ed997c1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: adds endpointing sensitivity to streaming recognition features
PiperOrigin-RevId: 871987204
Library-IDs: google-cloud-speech
Source-link: googleapis/googleapis@b2f57f3e
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Remove single quotes from DatabaseCenter summary.
PiperOrigin-RevId: 871778449
Library-IDs: google-cloud-databasecenter
Source-link: googleapis/googleapis@4ed62e49
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Replace "GCP" with "Google Cloud" in API comments
PiperOrigin-RevId: 871778449
Library-IDs: google-cloud-databasecenter
Source-link: googleapis/googleapis@4ed62e49
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@1133adb1
(exclusive) and
googleapis/googleapis@1e6955c6
(inclusive).
Librarian Version: v0.0.0-20260216162532-e323d455c92b
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c
Generation failed for