Conversation
* add google-oauthlib-tool Commandline tool to generate credentials using 3LO oauth2 flow. See: googleapis/google-auth-library-python#152
Resolves #5
Resolves #8
* Marks local web server test as a webtest Once imported internally, we'll use this to control test execution. * Update test_flow.py
After running this in a different CI environment, I had issues with the test being unable to open port 8080 as it was already in use. This doesn't fix the problem perfectly but is less likely to encounter a collision.
* Accept redirect_uri as arg to flow creating classmethods. * Attend to lint complaints. * Get the redirect_uri from kwargs.
Release v0.2.0
…brary-python-oauthlib into release-v0.3.0
Release v0.3.0
Fix links after repo move to googleapis.
…33) * Use actual server port in redirect_uri. Allows setting port to 0 to request an unassigned ephemeral port * Reformat to match linter rules
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request executes a significant architectural change by migrating the existing Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates the google-auth-oauthlib library into this monorepo. The changes are extensive, involving the addition of source code, documentation, and CI/CD configuration. The migration seems mostly correct, but I've identified a few issues: a broken link in the changelog, a configuration issue in the documentation build that would lead to a missing version number, and a critical security vulnerability related to the use of an unsafe function in a helper script. My review comments provide details and suggestions for these points.
| # See also: https://github.com/docascode/sphinx-docfx-yaml/issues/85 | ||
| sys.path.insert(0, os.path.abspath(".")) | ||
|
|
||
| __version__ = "" |
There was a problem hiding this comment.
The __version__ variable is initialized to an empty string and is not updated. This will cause the version to be missing from the generated documentation. Please read the version dynamically from setup.py.
| __version__ = "" | |
| import re | |
| with open(os.path.join(os.path.dirname(__file__), "..", "setup.py")) as f: | |
| setup_contents = f.read() | |
| version_match = re.search(r"version = \"(.*?)\"", setup_contents) | |
| __version__ = version_match.group(1) |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This PR is ready for review but not merge |
See #14910.
This PR should be merged with a merge-commit, not a squash-commit, in order to preserve the git history.