Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b2e12e7
fix(storage): standardize URL formatting and enhance transport retry
thiyaguk09 May 7, 2026
3bef808
fix(storage): gaxios migration system test fix
thiyaguk09 May 12, 2026
65f9f33
fix(storage): standardize URL formatting and enhance transport retry
thiyaguk09 May 7, 2026
1ae557f
refactor(storage): remove Service.ts and migrate logic to StorageTran…
thiyaguk09 May 14, 2026
2ad0450
Merge branch 'storage-node-18' into node18/system-test
thiyaguk09 May 14, 2026
bd33380
fix(storage): standardize URL formatting and enhance transport retry
thiyaguk09 May 7, 2026
cc411a0
refactor(storage): remove Service.ts and migrate logic to StorageTran…
thiyaguk09 May 14, 2026
fbeddaf
Merge remote-tracking branch 'upstream/storage-node-18' into node18/s…
thiyaguk09 May 14, 2026
128bf0a
fix(storage): standardize URL formatting and enhance transport retry
thiyaguk09 May 7, 2026
9010041
refactor(storage): remove Service.ts and migrate logic to StorageTran…
thiyaguk09 May 14, 2026
23ad973
Merge remote-tracking branch 'upstream/storage-node-18' into node18/s…
thiyaguk09 May 15, 2026
7b6d68b
fix(storage): standardize URL formatting and enhance transport retry
thiyaguk09 May 7, 2026
0e8f067
refactor(storage): remove Service.ts and migrate logic to StorageTran…
thiyaguk09 May 14, 2026
68ef48f
Merge remote-tracking branch 'upstream/storage-node-18' into node18/s…
thiyaguk09 May 18, 2026
a2cd00b
fix(storage): standardize URL formatting and enhance transport retry
thiyaguk09 May 7, 2026
72c17d7
refactor(storage): remove Service.ts and migrate logic to StorageTran…
thiyaguk09 May 14, 2026
7a7f79a
Merge remote-tracking branch 'upstream/storage-node-18' into node18/s…
thiyaguk09 May 19, 2026
0d254db
Merge remote-tracking branch 'upstream/storage-node-18' into node18/s…
thiyaguk09 May 21, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions handwritten/storage/system-test/fixtures/index-cjs.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// eslint-disable-next-line no-undef
/* eslint-disable node/no-missing-require, no-unused-vars, no-undef */
const {Storage} = require('@google-cloud/storage');

function main() {
// eslint-disable-next-line no-unused-vars
const storage = new Storage();
}

Expand Down
5 changes: 2 additions & 3 deletions handwritten/storage/system-test/fixtures/index-esm.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// eslint-disable-next-line no-undef
const {Storage} = require('@google-cloud/storage');
/* eslint-disable node/no-missing-import, no-unused-vars */
import {Storage} from '@google-cloud/storage';

function main() {
// eslint-disable-next-line no-unused-vars
const storage = new Storage();
}

Expand Down
7 changes: 5 additions & 2 deletions handwritten/storage/system-test/kitchen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ describe('resumable-upload', () => {
retryableErrorFn: RETRYABLE_ERR_FN_DEFAULT,
};

const bucket = new Storage({retryOptions}).bucket(bucketName);
const bucket = new Storage({
projectId: process.env.PROJECT_ID,
retryOptions: retryOptions,
}).bucket(bucketName);
let filePath: string;

before(async () => {
Expand Down Expand Up @@ -97,7 +100,7 @@ describe('resumable-upload', () => {
// see: https://cloud.google.com/storage/docs/exponential-backoff:
const ms = Math.pow(2, retries) * 1000 + Math.random() * 2000;
console.info(`retrying "${title}" in ${ms}ms`);
setTimeout(done(), ms);
setTimeout(() => done(), ms);
}

it('should work', done => {
Expand Down
Loading
Loading