Skip to content

fix(storage): Add telemetry tracing support for async stream Close()#16118

Open
kalragauri wants to merge 1 commit into
googleapis:mainfrom
kalragauri:feature/appendable-close
Open

fix(storage): Add telemetry tracing support for async stream Close()#16118
kalragauri wants to merge 1 commit into
googleapis:mainfrom
kalragauri:feature/appendable-close

Conversation

@kalragauri
Copy link
Copy Markdown
Contributor

This PR introduces OpenTelemetry tracing support for the newly introduced GCS Close() operation in the connection wrapper, ensuring end-to-end observability on connection half-close teardowns. This is a follow-up to #16112.

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label May 27, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the Close method override in AsyncWriterConnectionTracing to enable OpenTelemetry tracing for close operations. It captures metadata such as message type, message ID, thread ID, and payload size, and logs a "gl-cpp.close" event. Additionally, corresponding unit tests (Close and CloseError) have been added to verify successful and failed close operations and their tracing events. I have no feedback to provide as there are no review comments.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.71%. Comparing base (77109ef) to head (960211a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16118   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files        2353     2353           
  Lines      219274   219314   +40     
=======================================
+ Hits       203303   203342   +39     
- Misses      15971    15972    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalragauri kalragauri marked this pull request as ready for review May 27, 2026 07:03
@kalragauri kalragauri requested review from a team as code owners May 27, 2026 07:03
@kalragauri kalragauri requested a review from v-pratap May 27, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant