This repository was archived by the owner on Nov 18, 2025. It is now read-only.
chore: deprecate unsafe client options#1804
Closed
GautamSharda wants to merge 3 commits into
Closed
Conversation
GautamSharda
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
GautamSharda
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecates the keyFilename and credentials constructor options in ClientOptions to mitigate a security vulnerability. This change adds detailed JSDoc warnings guiding users to adopt a safer, explicit credential loading pattern by creating an auth object via google-auth-library before passing it to a client constructor.
Impact
Users relying on the keyFilename or credentials options will now see deprecation warnings in their IDEs and potentially in logs, encouraging them to migrate to the more secure credential handling mechanism.
Testing
No new tests or changed tests.
Checklist
places that require background
Fixes b/437993913