feat: add json_name support to compliance suite#1629
Open
diegomarquezp wants to merge 6 commits into
Open
Conversation
diegomarquezp
force-pushed
the
feat-json-name-compliance
branch
from
28df8d3 to
d71566c
Compare
…arquezp/gapic-showcase into feat-json-name-compliance
coryan
approved these changes
May 4, 2026
coryan
approved these changes
May 4, 2026
blakeli0
reviewed
May 4, 2026
| LifeKingdom f_kingdom = 22; | ||
|
|
||
| ComplianceDataChild f_child = 16; | ||
| string custom_path_field = 24 [json_name = "customPath"]; |
Contributor
There was a problem hiding this comment.
Is this intended to be used for path parameters? If yes, I think it needs to be configured in the RPC's http annotation?
Author
There was a problem hiding this comment.
Yes, the demo PR shows this would be respected googleapis/google-cloud-java#12980
| // versions: | ||
| // protoc-gen-go v1.33.0 | ||
| // protoc v3.20.3 | ||
| // protoc v7.34.1 |
Contributor
There was a problem hiding this comment.
Is this protoc version in the gen code intended? cc: @noahdietz who might be more familiar with the gapic-showcase setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds cases for the
json_namefield annotation to the compliance transcoding suite, referencing AIP-127.