chore: adopt dart native build hooks#236
Conversation
|
This is awesome! But we probably need to fix lints and get the tests to pass :D |
|
Do we have any idea what is wrong with the desktop platforms? |
HamdaanAliQuatil
force-pushed
the
native-hooks
branch
from
69dc9ac to
41d9fa3
Compare
HamdaanAliQuatil
force-pushed
the
native-hooks
branch
3 times, most recently
from
a67960b to
aa44b69
Compare
HamdaanAliQuatil
force-pushed
the
native-hooks
branch
from
c03e649 to
1b06bd8
Compare
jonasfj
left a comment
jonasfj
left a comment
There was a problem hiding this comment.
I've updated coveralls to not complain about small drops in coverage.
| }; | ||
| } | ||
|
|
||
| _VoidLookup _createLegacyLookup() { |
There was a problem hiding this comment.
Do we need to keep this around? same with bin/setup.dart?
I'm asking is there a need for these? Are native assets not available during tests or something like that?
Also we should update CHANGELOG.md
There was a problem hiding this comment.
I verified the native asset path works in both dart test and flutter test now.
I kept the legacy lookup path and bin/setup.dart in this PR as a compatibility layer because the current master still has CI/docs using flutter pub run webcrypto:setup. Let's create a follow-up PR that updates the workflows and README together, rather than mixing the deprecation/removal into this branch.
3 participants
Closes #192