Skip to content

RCE bug fix correction, handling paths and slashes #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamiesonpepper merged 1 commit into from
Mar 13, 2026
Merged

RCE bug fix correction, handling paths and slashes #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions docker/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ def upload_files():
if file.filename == '':
continue

filename = secure_filename(file.filename)
# Ensure we replace Windows paths with Linux paths before secure_filename
# because on Linux, secure_filename does not strip backslashes by default.
filename = secure_filename(file.filename.replace('\\', '/'))
filepath = os.path.join(app.config['UPLOAD_FOLDER'], filename)
file.save(filepath)

Expand Down Expand Up @@ -93,7 +95,7 @@ def inject_metadata():
results = []

for raw_filename in files_to_process:
filename = secure_filename(raw_filename)
filename = secure_filename(raw_filename.replace('\\', '/'))
input_path = os.path.join(app.config['UPLOAD_FOLDER'], filename)
output_filename = f"injected_{filename}"
output_path = os.path.join(app.config['UPLOAD_FOLDER'], output_filename)
Expand Down Expand Up @@ -130,7 +132,7 @@ def inject_metadata():

@app.route('/download/<filename>')
def download_file(filename):
secure_name = secure_filename(filename)
secure_name = secure_filename(filename.replace('\\', '/'))
return send_file(os.path.join(app.config['UPLOAD_FOLDER'], secure_name), as_attachment=True)

if __name__ == '__main__':
Expand Down