chore: upgrade nodejs/nan to 2.22

[benminer]

This PR upgrades nan to version 2.22, ensuring compatibility on NodeJS 21 and greater.

The main culprit when building pprof was SetAccessor being renamed, see here: nodejs/nan@6bd62c9

npm run test: ✅
system-test/system_test.sh: ✅

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[aabmass]

Thanks for the PR @benminer! Are you able to sign the CLA?

[aabmass]

Also please see the conventional commits check and update the commit/PR

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.92%. Comparing base (dead429) to head (a4e49e7).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   41.92%   41.92%           
=======================================
  Files          14       14           
  Lines        2092     2092           
  Branches       42       42           
=======================================
  Hits          877      877           
  Misses       1197     1197           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[benminer]

Thanks for the PR @benminer! Are you able to sign the CLA?

Hey @aabmass - thanks for checking in. I did, but looks like it went under my default Gmail account rather than the address I committed with. Fixed now - is there a way to re-run that check? Looks like it reran with my amended commit push.

Also please see the conventional commits check and update the commit/PR

For sure, should be good now!

[aabmass]

Thanks! I'll try to enable Node 21 tests and see what happens. There were some test failures #283 idk if you have any idea on that?

[benminer]

Thanks! I'll try to enable Node 21 tests and see what happens. There were some test failures #283 idk if you have any idea on that?

I'll check it out!

[yosiat]

Hi there,

I'm encountering the following error when attempting to upgrade my services to Node 22:

npm error /Users/USER/Library/Caches/node-gyp/22.14.0/include/node/v8-template.h:1049:8: note: candidate function not viable: no known conversion from 'imp::NativeGetter' (aka 'void (*)(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value> &)') to 'AccessorGetterCallback' (aka 'void (*)(Local<String>, const PropertyCallbackInfo<Value> &)') for 2nd argument
npm error  1049 |   void SetAccessor(
npm error       |        ^
npm error  1050 |       Local<String> name, AccessorGetterCallback getter,
npm error       |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
npm error In file included from ../bindings/profiler.cc:19:
npm error ../../nan/nan.h:2594:8: error: no matching member function for call to 'SetAccessor'
npm error  2594 |   tpl->SetAccessor(
npm error       |   ~~~~~^~~~~~~~~~~
npm error /Users/USER/Library/Caches/node-gyp/22.14.0/include/node/v8-template.h:1055:8: note: candidate function not viable: no known conversion from 'v8::AccessControl' to 'PropertyAttribute' for 5th argument
npm error  1055 |   void SetAccessor(
npm error       |        ^
npm error  1056 |       Local<Name> name, AccessorNameGetterCallback getter,
npm error  1057 |       AccessorNameSetterCallback setter = nullptr,
npm error  1058 |       Local<Value> data = Local<Value>(), PropertyAttribute attribute = None,
npm error       |                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
npm error /Users/USER/Library/Caches/node-gyp/22.14.0/include/node/v8-template.h:1049:8: note: candidate function not viable: no known conversion from 'imp::NativeGetter' (aka 'void (*)(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value> &)') to 'AccessorGetterCallback' (aka 'void (*)(Local<String>, const PropertyCallbackInfo<Value> &)') for 2nd argument

It looks like an update to nan should resolve the issue. Is there any chance a new release could be made with this upgrade?

Thanks!