Enable jitting in pcre2#11195
Conversation
|
addisoncrump is a new contributor to projects/pcre2. The PR must be approved by known contributors before it can be merged. The past contributors are: joycebrum, PhilipHazel, devtty1er, inferno-chromium, Dor1s, ssbr (unverified), mikea (unverified), kcwu (unverified) |
|
The linked PR has now been merged, so this should be ready to go. CI should probably be re-run as the latest changes from upstream need to be tested. |
|
There was an issue in the original PR. Please wait before merging! :) |
|
Blocked by PCRE2Project/pcre2#322 which should be merged relatively soon. |
|
Upstream has updated, can this PR be evaluated? |
|
Build failures are due to known abort()s in the fuzzer target. I can temporarily disable these, or put them behind a build flag for now. |
|
This pull request looks OK to me. |
PhilipHazel
left a comment
PhilipHazel
left a comment
There was a problem hiding this comment.
These changes seem fine.
|
Pipeline should be fully re-evaluated as upstream has been fixed to address the checks. |
addisoncrump
force-pushed
the
pcre2-enable-jit
branch
from
ba41dc1 to
7971713
Compare
addisoncrump
force-pushed
the
pcre2-enable-jit
branch
from
7971713 to
e279ef4
Compare
|
good to know: rebasing with GitHub creates unverified commits, very annoying |
|
This PR is now ready to merge if CI checks pass. |
|
Apologies for the issue. It seems my local brace expansion differs from CI; I have made this explicit, so this should now work as expected. |
Restarted the CI |
3 participants
This corresponds to an issue on PCRE2 regarding fuzzer improvements w.r.t. JIT: PCRE2Project/pcre2#317