neper: fix histogram printing in csv files.#25
Open
chenshuo wants to merge 1 commit intogoogle:masterfrom
Open
neper: fix histogram printing in csv files.#25chenshuo wants to merge 1 commit intogoogle:masterfrom
chenshuo wants to merge 1 commit intogoogle:masterfrom
Conversation
The quantiles in rr_snap_opaque struct are in seconds, not microseconds, no longer need to divide by 1,000,000.
wdebruij
reviewed
Feb 11, 2021
Collaborator
wdebruij
left a comment
wdebruij
left a comment
There was a problem hiding this comment.
Was this a bug all this time?
Changing output of the test may cause breakage of any tools, such as continuous testing infra, that is built on it.
Contributor
yes it looks like this was a bug all the time and the feature was unused.
The output format is not changed, so any tool built on top of it must continue to work (if not, there is a bug in the tool that uses the output). The patch only makes the output values correct, instead of printing all zeros (which makes any test using the current output pointless). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quantiles in rr_snap_opaque struct are in seconds, not microseconds,
no longer need to divide by 1,000,000.