Skip to content

Add installation instructions using crates.io#1329

Merged
ia0 merged 2 commits intogoogle:mainfrom
ia0:doc
Mar 19, 2026
Merged

Add installation instructions using crates.io#1329
ia0 merged 2 commits intogoogle:mainfrom
ia0:doc

Conversation

@ia0
Copy link
Copy Markdown
Member

@ia0 ia0 commented Mar 19, 2026

Fixes #1322

@ia0 ia0 requested a review from reyammer as a code owner March 19, 2026 08:04
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds installation instructions for the Rust CLI using cargo. I've noticed an inconsistency between the package name used in the new documentation (magika-cli) and the package name defined in the project's Cargo.toml (magika). My review includes a suggestion to align the documentation with the current configuration to prevent user confusion and installation errors.

Comment thread README.md
@ia0 ia0 enabled auto-merge (squash) March 19, 2026 09:25
@ia0 ia0 merged commit fece437 into google:main Mar 19, 2026
11 checks passed
@ia0 ia0 deleted the doc branch March 19, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows install from source failure - Error: Failed to load model because protobuf parsing failed.

2 participants