Refactor CollectAnnotatedSymbolsPsiVisitor#2932
Merged
Conversation
jaschdoc
force-pushed
the
rewrite-psi-visitor
branch
2 times, most recently
from
c13776b to
54b2e81
Compare
The visitor now considers Kotlin or Java elements that could be annotated and adds them to the list of results if there any annotations. This is more resilient that checking for every possible case of how an annotation might occur and relying on its internal structure which might change in the future or have edge cases.
jaschdoc
force-pushed
the
rewrite-psi-visitor
branch
from
54b2e81 to
b843435
Compare
troelsbjerre
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The visitor now considers annotated elements instead of visiting annotations and then relying / knowing the internal structure of the AST to find the annotated elements. This implementation should be more resilient since it only assumes the API to be correct instead of the internal tree structure of the program.