Python abi3#1289
Merged
johnbartholomew merged 7 commits intogoogle:masterfrom Feb 26, 2026
Merged
Conversation
8b3af70 to
4bcaa59
Compare
af6a26e to
5f48df6
Compare
Requires 3.10 because it uses PyUnicode_AsUTF8AndSize which was added (or added to the limited api) in 3.10.
macos-13 is no longer available as a GitHub standard runner.
5f48df6 to
338d4ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #1282
Various things here:
PyUnicode_AsUTF8AndSize()is only available from Python 3.10. We should use it but I'm hoping to let the thing continue to build on somewhat older Python versions than that so I've added a fallback path usingPyUnicode_AsUTF8String(). It's a bit of a pain.macos-14, because GitHub no longer has amacos-13runner available.setup.pyhas been moved topyproject.toml. The version is still dynamic and still set insetup.py(because version is looked up from jsonnet.h)Probably still needs a bit more testing, but at least cibuildwheel thinks it has produced a bunch of working wheel files.