Add rolled rotate-and-reduce kernel#2699
Merged
copybara-service[bot] merged 1 commit intogoogle:mainfrom Feb 27, 2026
Merged
Conversation
j2kun
force-pushed
the
arithmetic-dag-kernel-impl
branch
7 times, most recently
from
2ae9a3b to
c131524
Compare
j2kun
changed the title
j2kun
force-pushed
the
arithmetic-dag-kernel-impl
branch
from
c131524 to
31837a7
Compare
j2kun
added
the
pull_ready
Collaborator
Author
|
Marking as pull_ready so I can patch internal work over this PR |
j2kun
force-pushed
the
arithmetic-dag-kernel-impl
branch
from
31837a7 to
8a8fccb
Compare
j2kun
removed
the
pull_ready
asraa
approved these changes
Feb 27, 2026
j2kun
force-pushed
the
arithmetic-dag-kernel-impl
branch
from
8a8fccb to
3ed180a
Compare
j2kun
added
the
pull_ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
unrollAPI option to the KernelImplementation.h rotate and reduce kernels. Doesn't yet add a pass option to enable it due to the lack of rotation key analysis.As per discussion with @asraa, I'm leaving out the zeroDiagonals support until a followup PR