Skip to content

Update Jacoco exclusion list#3596

Open
shobhitagarwal1612 wants to merge 2 commits intomasterfrom
test-coverage
Open

Update Jacoco exclusion list#3596
shobhitagarwal1612 wants to merge 2 commits intomasterfrom
test-coverage

Conversation

@shobhitagarwal1612
Copy link
Member

Fixes #2824

  • Add proto and migration packages to exclusions.
  • Remove numerous specific class and package exclusions.

@andreia-ferreira PTAL?

- Add `proto` and `migration` packages to exclusions.
- Remove numerous specific class and package exclusions, including various Firebase schema references, map-related managers, abstract components, and utility classes.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Jacoco code coverage exclusion list to enhance the accuracy and maintainability of coverage reports. It introduces new exclusions for proto and migration packages, refactors existing Firebase-related exclusions to align with updated package structures, and simplifies the overall list by removing many granular, specific exclusions.

Highlights

  • New Exclusions Added: The proto and migration packages were added to the Jacoco exclusion list to prevent their code from being included in coverage reports.
  • Firebase Exclusions Refactored: Firebase-related exclusion paths were updated from persistence/remote/firebase to data/remote/firebase and generalized using *Reference* wildcards for schema classes.
  • Exclusion List Simplified: A significant number of specific class and package exclusions were removed, streamlining the Jacoco configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • config/jacoco/jacoco.gradle
    • Added **/proto/* and **/migration/* to the exclusion list.
    • Updated Firebase-related exclusion patterns, changing persistence/remote/firebase to data/remote/firebase and generalizing schema references.
    • Removed a large number of specific class and package exclusions.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates and simplifies the Jacoco code coverage exclusion list. It removes a large number of specific file exclusions, adds broader patterns, and updates paths for moved packages. This is a positive change for maintainability. However, I found a small typo in one of the new exclusion patterns that would prevent it from working as intended.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.33%. Comparing base (f66c5d5) to head (fa93456).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3596      +/-   ##
============================================
- Coverage     71.07%   70.33%   -0.74%     
- Complexity     1628     1816     +188     
============================================
  Files           338      353      +15     
  Lines          9114     9895     +781     
  Branches       1003     1061      +58     
============================================
+ Hits           6478     6960     +482     
- Misses         2034     2300     +266     
- Partials        602      635      +33     

see 51 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code health] Re-enable test coverage for non-trivial Fragments

1 participant