Skip to content

Add Thai and Lao languages#3591

Merged
andreia-ferreira merged 8 commits intomasterfrom
andreia/3546/add-thai-and-lao
Mar 6, 2026
Merged

Add Thai and Lao languages#3591
andreia-ferreira merged 8 commits intomasterfrom
andreia/3546/add-thai-and-lao

Conversation

@andreia-ferreira
Copy link
Collaborator

Fixes #3546
This PR adds the string resources for these 2 languages and the possibility to choose them in the settings page

Screen_recording_20260304_110946.webm

@shobhitagarwal1612 PTAL?

@auto-assign auto-assign bot requested a review from gino-m March 4, 2026 10:13
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's internationalization by introducing support for Thai and Lao languages. The changes involve adding comprehensive string resources for both languages and making them selectable in the user settings, thereby broadening the application's reach to a larger global audience.

Highlights

  • New Language Support: Added full support for Thai and Lao languages, including all necessary string resources.
  • Settings Integration: Enabled the selection of Thai and Lao languages within the application's settings page.
  • Bug Fix: Resolved issue Add support for Thai and Lao #3546, which likely pertained to the absence of these language options.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • app/src/main/res/values-es/strings.xml
    • Added Spanish translations for 'Thai' and 'Lao' language names.
  • app/src/main/res/values-fr/strings.xml
    • Added French translations for 'Thai' and 'Lao' language names.
  • app/src/main/res/values-lo/strings.xml
    • Added a new file containing all Lao language string resources.
  • app/src/main/res/values-pt/strings.xml
    • Added Portuguese translations for 'Thai' and 'Lao' language names.
  • app/src/main/res/values-th/strings.xml
    • Added a new file containing all Thai language string resources.
  • app/src/main/res/values-vi/strings.xml
    • Added Vietnamese translations for 'Thai' and 'Lao' language names.
  • app/src/main/res/values/arrays.xml
    • Updated the 'language_entries' and 'language_entry_values' arrays to include Thai and Lao.
  • app/src/main/res/values/strings.xml
    • Added English string definitions for 'Thai' and 'Lao' language names.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Thai and Lao languages by introducing new string resource files and updating existing ones. While the initiative is great, the implementation has some critical issues. The Thai resource file (values-th/strings.xml) contains a significant number of strings that are incorrectly translated into Lao, which needs to be fixed. Additionally, both new resource files have an incorrect copyright year, and the Lao file contains some untranslated strings. There are also minor formatting inconsistencies in the new files that should be addressed for maintainability.

Note: Security Review has been skipped due to the limited scope of the PR.

andreia-ferreira and others added 3 commits March 4, 2026 11:20
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.07%. Comparing base (db59fc7) to head (bfca476).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3591      +/-   ##
============================================
- Coverage     71.11%   71.07%   -0.04%     
+ Complexity     1629     1628       -1     
============================================
  Files           338      338              
  Lines          9114     9114              
  Branches       1003     1003              
============================================
- Hits           6481     6478       -3     
- Misses         2031     2034       +3     
  Partials        602      602              

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address all comments by Gemini bot before submitting.

@andreia-ferreira
Copy link
Collaborator Author

updated the files with the correct translations, so it's now ready to merge

@andreia-ferreira andreia-ferreira merged commit f66c5d5 into master Mar 6, 2026
9 checks passed
@andreia-ferreira andreia-ferreira deleted the andreia/3546/add-thai-and-lao branch March 6, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Thai and Lao

2 participants