Add allow_unknown_config option to ModelStore.#843
Open
copybara-service[bot] wants to merge 1 commit intodevfrom
Open
Add allow_unknown_config option to ModelStore.#843copybara-service[bot] wants to merge 1 commit intodevfrom
allow_unknown_config option to ModelStore.#843copybara-service[bot] wants to merge 1 commit intodevfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_874817169
branch
from
c3a2e4d to
8d73061
Compare
copybara-service
bot
changed the title
allow_unknown_config option to ModelStore.
This change introduces an `allow_unknown_config` parameter to the ModelStore constructor. When set to true, if a ModelConfig is present in the blob, the model type deduction is skipped. This allow Gemma.cpp to work with custom models without having to hardcode their parameters. PiperOrigin-RevId: 874817169
copybara-service
bot
force-pushed
the
test_874817169
branch
from
8d73061 to
00d66ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
allow_unknown_configoption to ModelStore.This change introduces an
allow_unknown_configparameter to the ModelStore constructor. When set to true, if a ModelConfig is present in the blob, the model type deduction is skipped. This allow Gemma.cpp to work with custom models without having to hardcode their parameters.