Skip to content

Add missing runtime retention to scope and qualifier annotations in tests #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Feb 25, 2026
Merged

Add missing runtime retention to scope and qualifier annotations in tests #5131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions javatests/dagger/functional/jakarta/JakartaProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
import jakarta.inject.Provider;
import jakarta.inject.Qualifier;
import jakarta.inject.Scope;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.util.HashMap;
import java.util.Map;
import org.junit.Test;
Expand All @@ -41,9 +43,11 @@
@RunWith(JUnit4.class)
public final class JakartaProviderTest {

@Retention(RetentionPolicy.RUNTIME)
@Scope
public @interface TestScope {}

@Retention(RetentionPolicy.RUNTIME)
@Qualifier
public @interface TestQualifier {}

Expand Down
4 changes: 4 additions & 0 deletions javatests/dagger/functional/jakarta/SimpleJakartaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,20 @@
import jakarta.inject.Inject;
import jakarta.inject.Qualifier;
import jakarta.inject.Scope;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;

@RunWith(JUnit4.class)
public final class SimpleJakartaTest {

@Retention(RetentionPolicy.RUNTIME)
@Scope
public @interface TestScope {}

@Retention(RetentionPolicy.RUNTIME)
@Qualifier
public @interface TestQualifier {}

Expand Down
Loading