Fix padding handling in note parsing resulting in "region out-of-bounds"#491
Open
0xd34df00d wants to merge 1 commit intogoogle:mainfrom
Open
Fix padding handling in note parsing resulting in "region out-of-bounds"#4910xd34df00d wants to merge 1 commit intogoogle:mainfrom
0xd34df00d wants to merge 1 commit intogoogle:mainfrom
Conversation
The actual note content might not be well-aligned, so the linker might pad the section. In this case, `remaining_` will _not_ be empty, but it might not be big enough to read a full `Elf_Note` header, resulting in an out-of-bounds access. This fixes failures on some binaries resulting in > bloaty: region out-of-bounds In particular, this happens with Qt binaries which embed `.note.qt.metadata` section with pretty much arbitrary internal length.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Apparently #390 is also related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual note content might not be well-aligned, so the linker might pad the section. In this case,
remaining_will not be empty, but it might not be big enough to read a fullElf_Noteheader, resulting in an out-of-bounds access.This fixes failures on some binaries resulting in
In particular, this happens with Qt binaries which embed
.note.qt.metadatasection with pretty much arbitrary internal length.I've run tests locally, and no new tests fail (my local run fails
EmptyObjectFile,SimpleObjectFileandSimpleArchiveFile, but that also happens on master).