chore: Add a suitable devcontainer.json#915
Conversation
Summary of ChangesHello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a devcontainer.json file to standardize the development environment, which is a great addition for improving contributor experience, especially with GitHub Codespaces. The configuration correctly sets up a Java 17 environment, aligning with the project's requirements. I have a few suggestions to further refine the configuration for better performance, correctness, and usability: fixing a syntax error in the JSON, removing a potentially redundant VS Code extension, adjusting a build setting for faster builds, and adding a port forwarding rule to match the project's documentation.
Primarily so that "it just works" (which it does not, without this, because of a Java version mismatch).
c60d99a to
b6ebfc5
Compare
Primarily so that "it just works" (which it does not, without this, because of a Java version mismatch).
This would help me to contribute to this project more easily by making GitHub Codespaces to just work out of the box.
I've tried it and seen that this needed while trying to rebase #487 (and maybe #374).
@glaforge LGTM?