Skip to content

chore: Add a suitable devcontainer.json#915

Open
vorburger wants to merge 1 commit intogoogle:mainfrom
vorburger:github_codespace_java17
Open

chore: Add a suitable devcontainer.json#915
vorburger wants to merge 1 commit intogoogle:mainfrom
vorburger:github_codespace_java17

Conversation

@vorburger
Copy link
Member

Primarily so that "it just works" (which it does not, without this, because of a Java version mismatch).

This would help me to contribute to this project more easily by making GitHub Codespaces to just work out of the box.

I've tried it and seen that this needed while trying to rebase #487 (and maybe #374).

@glaforge LGTM?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a .devcontainer.json file to facilitate easier project contribution by providing a consistent and pre-configured development environment within GitHub Codespaces. It addresses Java versioning issues and sets up essential tools and extensions for Java development.

Highlights

  • Devcontainer Setup: This PR introduces a .devcontainer.json file to streamline the development environment setup using GitHub Codespaces.
  • Java Version Consistency: The primary motivation is to resolve Java version mismatches, ensuring a smoother 'it just works' experience for contributors.
  • Dependency Management: The devcontainer configuration includes pre-installed extensions and settings tailored for Java development, enhancing the out-of-the-box experience.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .devcontainer/devcontainer.json
    • Added a devcontainer configuration file to define the development environment.
Activity
  • The PR aims to simplify the setup process for new contributors.
  • It was created to address issues encountered while rebasing other pull requests.
  • The author, vorburger, is seeking review and approval from glaforge.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a devcontainer.json file to standardize the development environment, which is a great addition for improving contributor experience, especially with GitHub Codespaces. The configuration correctly sets up a Java 17 environment, aligning with the project's requirements. I have a few suggestions to further refine the configuration for better performance, correctness, and usability: fixing a syntax error in the JSON, removing a potentially redundant VS Code extension, adjusting a build setting for faster builds, and adding a port forwarding rule to match the project's documentation.

Primarily so that "it just works" (which it does not, without this, because of a Java version mismatch).
@vorburger vorburger force-pushed the github_codespace_java17 branch from c60d99a to b6ebfc5 Compare February 26, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant