Skip to content

refactor: Replacing deprecated Runner.runAsync call #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+32 −13
Open

refactor: Replacing deprecated Runner.runAsync call #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contrib/langchain4j/src/test/java/com/google/adk/models/langchain4j/RunLoop.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ public static List<Event> runLoop(BaseAgent agent, boolean streaming, Object...
allEvents.addAll(
runner
.runAsync(
session,
session.userId(),
session.id(),
messageContent,
RunConfig.builder()
.setStreamingMode(
Expand Down
12 changes: 6 additions & 6 deletions contrib/spring-ai/src/test/java/com/google/adk/models/springai/SpringAIIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import static org.junit.jupiter.api.Assertions.*;

import com.google.adk.agents.LlmAgent;
import com.google.adk.agents.RunConfig;
import com.google.adk.events.Event;
import com.google.adk.models.springai.integrations.tools.WeatherTool;
import com.google.adk.runner.InMemoryRunner;
Expand Down Expand Up @@ -80,7 +81,7 @@ public ChatResponse call(Prompt prompt) {

List<Event> events =
runner
.runAsync(session, userMessage, com.google.adk.agents.RunConfig.builder().build())
.runAsync(session.userId(), session.id(), userMessage, RunConfig.builder().build())
.toList()
.blockingGet();

Expand Down Expand Up @@ -159,7 +160,7 @@ public ChatResponse call(Prompt prompt) {

List<Event> events =
runner
.runAsync(session, userMessage, com.google.adk.agents.RunConfig.builder().build())
.runAsync(session.userId(), session.id(), userMessage, RunConfig.builder().build())
.toList()
.blockingGet();

Expand Down Expand Up @@ -228,11 +229,10 @@ public Flux<ChatResponse> stream(Prompt prompt) {
List<Event> events =
runner
.runAsync(
session,
session.userId(),
session.id(),
userMessage,
com.google.adk.agents.RunConfig.builder()
.setStreamingMode(com.google.adk.agents.RunConfig.StreamingMode.SSE)
.build())
RunConfig.builder().setStreamingMode(RunConfig.StreamingMode.SSE).build())
.toList()
.blockingGet();

Expand Down
30 changes: 24 additions & 6 deletions contrib/spring-ai/src/test/java/com/google/adk/models/springai/TestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,19 @@
import com.google.genai.types.Part;
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;

public class TestUtils {

public static List<Event> askAgent(BaseAgent agent, boolean streaming, Object... messages) {
ArrayList<Event> allEvents = new ArrayList<>();

Runner runner = new InMemoryRunner(agent, agent.name());
Session session = runner.sessionService().createSession(agent.name(), "user132").blockingGet();
Session session =
runner
.sessionService()
.createSession(agent.name(), "user132-" + UUID.randomUUID())
.blockingGet();

for (Object message : messages) {
Content messageContent = null;
Expand All @@ -46,7 +51,8 @@ public static List<Event> askAgent(BaseAgent agent, boolean streaming, Object...
allEvents.addAll(
runner
.runAsync(
session,
session.userId(),
session.id(),
messageContent,
RunConfig.builder()
.setStreamingMode(
Expand All @@ -67,13 +73,20 @@ public static List<Event> askBlockingAgent(BaseAgent agent, Object... messages)
}

Runner runner = new InMemoryRunner(agent);
Session session = runner.sessionService().createSession("test-app", "test-user").blockingGet();
Session session =
runner
.sessionService()
.createSession("test-app", "test-user-" + UUID.randomUUID())
.blockingGet();

List<Event> events = new ArrayList<>();

for (Content content : contents) {
List<Event> batchEvents =
runner.runAsync(session, content, RunConfig.builder().build()).toList().blockingGet();
runner
.runAsync(session.userId(), session.id(), content, RunConfig.builder().build())
.toList()
.blockingGet();
events.addAll(batchEvents);
}

Expand All @@ -88,15 +101,20 @@ public static List<Event> askAgentStreaming(BaseAgent agent, Object... messages)
}

Runner runner = new InMemoryRunner(agent);
Session session = runner.sessionService().createSession("test-app", "test-user").blockingGet();
Session session =
runner
.sessionService()
.createSession("test-app", "test-user-" + UUID.randomUUID())
.blockingGet();

List<Event> events = new ArrayList<>();

for (Content content : contents) {
List<Event> batchEvents =
runner
.runAsync(
session,
session.userId(),
session.id(),
content,
RunConfig.builder().setStreamingMode(RunConfig.StreamingMode.SSE).build())
.toList()
Expand Down
Loading