Skip to content

Fix/dqn example#121

Open
KaleabTessera wants to merge 2 commits intogoogle-deepmind:mainfrom
KaleabTessera:fix/dqn-example
Open

Fix/dqn example#121
KaleabTessera wants to merge 2 commits intogoogle-deepmind:mainfrom
KaleabTessera:fix/dqn-example

Conversation

@KaleabTessera
Copy link
Copy Markdown

This PR includes two fixes for the dqn example:

  1. Fix import error:

    Traceback (most recent call last):
      File "examples/simple_dqn.py", line 28, in <module>
        from rlax.examples import experiment
    ModuleNotFoundError: No module named 'rlax.examples'
    

    There is already a PR for this, but this fixes the whole dqn example.

  2. Fix epsilon scheduling (Epsilon keeps getting reintialized in the example script #102).

    These lines (1 , 2) reset the actor steps, which results in the wrong counts being passed to the eps scheduling function here. This outcome of this is a cyclic eps schedule which is not intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant