v0.26.11: DX12 indirect dispatch/draw (BUG-DX12-012)#164
Merged
Conversation
…ture (BUG-DX12-012) Implement DispatchIndirect, DrawIndirect, DrawIndexedIndirect on DX12. Pre-create three ID3D12CommandSignature objects at device init (Rust wgpu-hal pattern): dispatch 12B, draw 16B, draw indexed 20B stride. DX12 was the last GPU backend with stub indirect methods.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecuteIndirectwith pre-createdID3D12CommandSignatureobjects (Rust wgpu-hal pattern)Test plan
go build ./...— Windows, Linux, macOSgo test ./...— all passgolangci-lint run— 0 issues on all 3 platformsgofmt -l .— cleandx12/device.rs:142-174,dx12/command.rs:1599-1630