fix(kqueue): preserve create events when child watch fails#10
Open
paralin wants to merge 1 commit intogofsnotify:mainfrom
Open
fix(kqueue): preserve create events when child watch fails#10paralin wants to merge 1 commit intogofsnotify:mainfrom
paralin wants to merge 1 commit intogofsnotify:mainfrom
Conversation
Member
|
Could you please rebase master? |
Signed-off-by: Christian Stewart <christian@aperture.us>
44cf550 to
6fe7354
Compare
Author
|
@mattn rebased! |
Member
|
Thanks for the patch. A few issues need to be addressed before this can land:
Also, the branch now conflicts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps directory Create notifications observable even when registering the new child watch fails, while still registering successful child watches before delivering Create so a following Write is not missed.
Tested with
go test ./....