This repository was archived by the owner on Jun 25, 2022. It is now read-only.
fix bug on resolving import path for diskImportTempl#265
Open
jsteuer wants to merge 1 commit intogobuffalo:masterfrom
jsteuer:master
Open
fix bug on resolving import path for diskImportTempl#265jsteuer wants to merge 1 commit intogobuffalo:masterfrom jsteuer:master
jsteuer wants to merge 1 commit intogobuffalo:masterfrom
jsteuer:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My GOPATH is
/home/jsteuer/go:/home/jsteuer/go_dev. If I run packr2 the generated*-packr.gocontains the following bad import.Because both paths are sharing the substring
/home/jsteuer/gothe algorithm to calculate the.Importpath fordiskImportTemplis depending on the order of the GOPATH. (IfGO111MODULE=onthe problem does not appears - thanks to #183). I think this is bug, so sorting the entries of the GOPATH solves this issue for me: