fix(exec): use client err for substitution failures and delay PlanStep#701
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
=======================================
Coverage 52.67% 52.67%
=======================================
Files 130 130
Lines 5635 5635
=======================================
Hits 2968 2968
Misses 2438 2438
Partials 229 229
🚀 New features to boost your workflow:
|
KellyMerrick
approved these changes
Apr 30, 2026
wass3rw3rk
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any substitution errors were failing silently and not being relayed to the user in any fashion. Further, because PlanStep was executed before the substitution, the step is marked as
runningand is not properly cleaned up.By using
c.err, the build will bomb out expectedly if there's a container config breaking error and will also set the upcoming step asskippedinstead ofsuccesswhen it's all said and done.Example Pipeline:
BEFORE:

AFTER:
