fix(artifacts): stream log to UI#700
Open
timhuynh94 wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
- Coverage 52.67% 52.25% -0.42%
==========================================
Files 130 130
Lines 5635 5680 +45
==========================================
Hits 2968 2968
- Misses 2438 2483 +45
Partials 229 229
🚀 New features to boost your workflow:
|
wass3rw3rk
requested changes
May 13, 2026
| // from the server to get the authoritative copy that includes all | ||
| // container output — this prevents artifact messages from overwriting | ||
| // the step's own logs. | ||
| time.Sleep(2 * time.Second) |
Member
There was a problem hiding this comment.
really not a fan of putting an arbitrary wait time here. is there some kind of event to hook into?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.