fix: preserve dotenv variable order#2855
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
Contributor
|
There is already this #2612 which IIRC also gets rid of the dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1847.
This keeps dotenv values in file order after parsing, so Task template expansion sees earlier dotenv entries before later nested entries. Both global and task-level dotenv loading now share the ordered reader while still using godotenv for parsing.
Tests run:
GOMODCACHE=/tmp/task-1847-gomodcache GOCACHE=/tmp/task-1847-gocache go test ./... -run TestDotenvNestedTemplatesAreEvaluatedInFileOrder -count=1GOMODCACHE=/tmp/task-1847-gomodcache GOCACHE=/tmp/task-1847-gocache go test ./... -run 'TestDotenv|TestTaskDotenv|TestVarInheritance' -count=1\n-GOMODCACHE=/tmp/task-1847-gomodcache GOCACHE=/tmp/task-1847-gocache go test ./...\n-GOMODCACHE=/tmp/task-1847-gomodcache GOCACHE=/tmp/task-1847-gocache go vet ./...\n-test -z "$(gofmt -l taskfile/dotenv.go variables.go task_test.go)"\n-git diff --cached --check\n\nAI assistance disclosure: I used AI assistance to draft and verify this patch, then reviewed the code and test output before submitting.\n\n- [x] I have read and followed the Contribution Guide\n