Adding buffer & channel for Marshall & UnMarshall, fixing performance…#6
Open
lchanouha wants to merge 1 commit intogo-ldap:masterfrom
Open
Adding buffer & channel for Marshall & UnMarshall, fixing performance…#6lchanouha wants to merge 1 commit intogo-ldap:masterfrom
lchanouha wants to merge 1 commit intogo-ldap:masterfrom
Conversation
… issues & memory usage which large files
Contributor
|
I just realised that I did similarly, except using the iterator pattern, to achieve the same streaming idiom within a single goroutine. |
Member
|
@adamluzsi Yes, but imo your implementation is cleaner. I'll close this PR once yours is merged. Thank you both anyways for your work! ❤️ |
Contributor
|
The writing / Encoder idiom still valuable for scavenging, but it might worth to prove its behaviour with tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… issues & memory usage which large files
Hello,
I use your library to import / export LDIF with > 150K entries.
This commit addresses:
I didn't change the behavior of Marshall and Unmarshall (same spec and error handling), to read / write
a lot of entries, theses functions are prefered:
This is one on my first go code, maybe this commit should me checked (go test passed).
Regards,