Fix RouteHeaders middleware to handle Host header correctly#1039
Open
nathannewyen wants to merge 1 commit intogo-chi:masterfrom
Open
Fix RouteHeaders middleware to handle Host header correctly#1039nathannewyen wants to merge 1 commit intogo-chi:masterfrom
nathannewyen wants to merge 1 commit intogo-chi:masterfrom
Conversation
Go's http server promotes the Host header to r.Host and removes it from
the Header map. This means r.Header.Get("Host") always returns empty.
This change adds special handling for the "Host" header to read from
r.Host instead, making the Host-based routing example actually work.
Also fixed the example in the documentation to avoid circular router
references which would cause a stack overflow.
Added tests for Host header routing behavior.
Fixes go-chi#691
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Go's http server promotes the Host header to
r.Hostand removes it from the Header map. This meansr.Header.Get("Host")always returns an empty string, making the Host-based routing example inRouteHeadersnon-functional.This change:
r.Hostinstead ofr.Header.Get("Host")Changes
r.HostTest Plan
r.HostFixes #691