feat: add a function to throttle scrolling events#564
Open
DaKoala wants to merge 1 commit intognab:developfrom
Open
feat: add a function to throttle scrolling events#564DaKoala wants to merge 1 commit intognab:developfrom
DaKoala wants to merge 1 commit intognab:developfrom
Conversation
peterj
reviewed
Jan 3, 2020
| var timestamp = null; | ||
| return function() { | ||
| var now = Date.now(); | ||
| if (timestamp === null || now - timestamp > 100) { |
Collaborator
There was a problem hiding this comment.
What do you think about making this optional?
Right now you can enable/disable scrolling - would it make sense to add an option to throttle and the time value e.g.:
var slideshow = remark.create({
navigation: {
scrollThrottle: 100, // default value would be 0 or the same behavior we have today.
}
});
|
Instead of this throttle-based implementation, which essentially slows down all users, regardless of how fast they are actually trying to scroll, how about listening to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the remark slideshow. If you scroll on your touch pad even a little, the slides will go forward/back multiple slides. I add a function to throttle emitters of scrolling. Therefore, the slides will only change by 1 when a user scrolls.