-
Notifications
You must be signed in to change notification settings - Fork 5
Performance-focused rewrite of the ConvexPolyhedron class #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
f0b8598
test: Fix assumption on quaternions.
b-butler ab21279
Added new classes to return the edges of polyhedra
janbridley 22399d8
Fixed return for get_edge_vectors method.
janbridley c9108cd
Merge branch 'master' into release-edgelengths
janbridley 7c94100
Renamed get_edge_vectors property to edge_vectors
janbridley 0e6501a
Vectorized edge_vectors return with numpy
janbridley fdec57c
Updated test_polyhedron to be compatible with the renamed edge_vector…
janbridley dd47ed2
Updated test_polyhedron to explicitly cover the edges property
janbridley 210f009
Updated rtol for edge property test
janbridley a2cfd3c
Reverted small fixes that account for inaccuracies in polyhedron stor…
janbridley 1f4a106
Removed unnecessary comment from ``test_edges``
janbridley d387fca
Changed ``edge_vectors`` property to return a numpy array
janbridley 6e69875
Merge branch 'release-edgelengths' of https://github.com/glotzerlab/c…
janbridley f473e27
Rewrote ``edges`` method and updated ``edge_vectors`` for compatibility
janbridley cd67d45
Updated ``test_polyhedron`` to work with set edges
janbridley 01077cc
Fixed docstring formatting for ``edges`` and ``edge_vectors``
janbridley ada7029
Updated edges method to return Numpy array
janbridley 7a89acb
test_polyhedron::test_edges now checks edge count
janbridley b03099b
Merge branch 'master' into release-edgelengths
janbridley 770199b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a879cc2
Merge branch 'master' into release-edgelengths
janbridley b4f60f9
Updated edges property to cache result
janbridley 6b72414
Updated edges and edge_vectors to make better use of numpy functions …
janbridley b502cf6
Updated documentation for ConvexPolyhedron rewrite
janbridley 2f22ab2
Updated __init__ and shape creation helpers
janbridley f598272
Updated centroid getter and setter
janbridley 5dfef18
Updated volume getter, setter, and _rescale function
janbridley 0d21d98
Improved _find_equations method
janbridley d5b202c
Added equations property
janbridley 2e3914c
Updated faces property to work with optional sorting
janbridley ed33ca6
Added normals property
janbridley 0dbc268
Updated sort_faces
janbridley e1a700d
Updated neighbors property
janbridley d5534be
Added simplices property and updated _surface_triangulation
janbridley a728486
Added _find_triangle_array_area helper
janbridley 135e0a1
Add faster surface area getter, setter, and calculation
janbridley f2c55e1
Added get_face_area method
janbridley 1721a9e
Added face_centroids property and _get_face_centroids
janbridley b62a3aa
Updated inertia_tensor property + _compute and diagonalize methods
janbridley 2fe4d05
Added get_dihedral
janbridley 158ac57
Added more stringent pytests for centroid and centroid setter
janbridley ffb09d8
Added in-depth tests for surface area and volume setters
janbridley 11f5bd3
Added circleci checker function to speed up local pytest runs
janbridley ac2b10b
Added Truncated Icosahedron to bad_shapes for test MOI
janbridley 8d22516
Added pytest for test_face_centroids and fixes for shape creation wit…
janbridley eee3cf5
Set fast flag to properly default to False
janbridley 184ec36
Fix typo in _consume_hull
janbridley e991851
Merge branch 'master' into update-ConvexPolyhedron
janbridley f783f67
Fixed documentation for Polyhedron class
janbridley cfa2956
Docstring formatting
janbridley 83408cf
Docstring formatting fix
janbridley 8a61dd5
Another docstring fix
janbridley 8df746a
One more docstring fix
janbridley f0355e0
Added tests for simplex equations, face equations, and normals
janbridley c676f18
Combined pytest marks to clean up testing code
janbridley 9bb5a10
Update Credits.rst
janbridley 0cf79cb
Added test for heavily degenerate input vertices
janbridley fd73adb
Merge branch 'master' into update-ConvexPolyhedron
janbridley 96a8c01
Merge branch 'master' into update-ConvexPolyhedron
janbridley 83e6642
Changed [test] to [tests]
janbridley e7bae59
Merge branch 'master' of https://github.com/glotzerlab/coxeter
janbridley 69a5c71
Merge branch 'master' into update-ConvexPolyhedron
janbridley 39490bb
Updated ConvexPolyhedron to properly handle nonconvex inputs.
janbridley 2fbe7bf
Removed use of Fast flag from class
janbridley f3561a5
Removed fast flag from credits
janbridley 266a15f
Updated ci flags for pytest
janbridley 23244fd
Fixed D202 in convex_polyhedron
janbridley 3e41640
Added ci check to MI test
janbridley a06564d
Merge branch 'master' into update-ConvexPolyhedron
janbridley 7cdcdf7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 01e0e6e
Merge branch 'master' into update-ConvexPolyhedron
janbridley ad30552
Updated tests
janbridley 815e731
Updated docstring for _calculate_signed_volume
janbridley 23de270
Removed degenerate cube test
janbridley 5a13055
Removed remaining circleci files
janbridley 261e3da
Began updating changelog
janbridley 16505be
Updating changelog
janbridley d62154a
Clarified language on faces breaking change
janbridley 571d5b5
Cleaned up convex hull handling
janbridley 6152313
Update coxeter/shapes/convex_polyhedron.py
janbridley 9aa4a59
Removed unnecessary call to principal_moments
janbridley 1ed3735
Fixed pytest fixture call
janbridley efa630c
Merge branch 'update-ConvexPolyhedron' of https://github.com/glotzerl…
janbridley 4fe9d88
Fixed bug in _find_coplanar_simplices
janbridley 778f69f
Removed copy of inherited method get_dihedral
janbridley 69f6aed
Merge branch 'master' into update-ConvexPolyhedron
janbridley d4ab951
Merge branch 'update-ConvexPolyhedron' of https://github.com/glotzerl…
janbridley d844a3c
Merge branch 'master' into update-ConvexPolyhedron
janbridley 6845450
Merge branch 'master' into update-ConvexPolyhedron
janbridley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.