You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have separated the addition process of competitions into the add_history method. This modification allows for incremental addition of competitions.
The existing interface remains unchanged.
To prevent inappropriate updating of last_time in agents, each newly added competition is compared with the min(times) of all previously added competitions. This check ensures that every newly added competition occurs after all competitions added prior to it.
Hi, I add a basic test to your branch for the proposed add_history method. You are relying on the trueskill method, that only serves at the first time. I recommend no touching it. Instead, there is an old unfinished method to add new events, called add_events. Maybe you can finish it. Below the new test you will see a commented test for add_events.
I'm sorry that I haven't been able to contribute for a while.
However, I'm delighted to hear that version 2.0.0—which includes the points discussed in this issue—is scheduled for release.
I’ve reviewed the content, and I think it looks excellent!
I’ve also created a #14 so that I can contribute even a little.
I'm looking forward to the release of version 2.0.0.
Thank you in advance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have separated the addition process of competitions into the
add_historymethod. This modification allows for incremental addition of competitions.The existing interface remains unchanged.
To prevent inappropriate updating of last_time in agents, each newly added competition is compared with the
min(times)of all previously added competitions. This check ensures that every newly added competition occurs after all competitions added prior to it.Do we need to create new tests for this feature?
Thank you for your review!