Add support for exclusion of field via field tag.#51
Add support for exclusion of field via field tag.#51NicklasWallgren wants to merge 2 commits intogkampitakis:mainfrom
Conversation
f493990 to
fb98d63
Compare
|
Hey, thanks a lot for the pr 😊 . Will have a look at it as soon as possible |
|
Sorry for the delay, first of all, thanks again for your contribution and for your interest in the library. I have some concerns with this solution. First, it's pretty clever using the tags, I never thought about it, but I am worried people are already making the structs really "crowded" with tags, not sure they would want to add to that long list another one that would be for tests only. I am not saying no I am just sharing thoughts and asking for feedback 😅 potentially on the |
|
Thanks for the reply! I wasn't aware that you were working on adding support for property matchers when I created this PR. I noticed #18, and thought that I was forced to implement my own snapshot-library, with support for matchers. I'm really glad you started working on I'm not to comfortable about the vendoring either. There is actually an open PR on |
|
Hey 👋, just to keep you on the loop haven't forgot about this pr. Just waiting if there is some interest on merging the pr you shared on pretty |
|
Closing this. If there is interest from pretty to imlpement it, I am happy to document this. |
With these changes, one can add a struct field tag go-snaps:"-" to ignore pretty printing a particular field.
It's a good option until support for matchers has been released.