Closed
Conversation
Amoghhosamane
force-pushed
the
fix/orientation-reset-74
branch
2 times, most recently
from
9ba3468 to
507bc62
Compare
Amoghhosamane
force-pushed
the
fix/orientation-reset-74
branch
from
507bc62 to
8fd7a3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description File:
pr_description_75.md
Branch: feature/auth-buttons-75
Compare & PR URL: Amoghhosamane/innerpod@dev...feature/auth-buttons-75
2. Fix for Issue #74: Timer State Preservation (Orientation Change)
PR Description File:
pr_description_74.md
Branch: fix/orientation-reset-74
Compare & PR URL: Amoghhosamane/innerpod@dev...fix/orientation-reset-74
Work Summary:
Verified: All changes have been linted (flutter analyze) and tested (flutter test), with all 5 tests passing.
Architectural Fix (#74): Added GlobalKey to
AppCircularCountDownTimer
and ValueKey to the inner
CircularCountDownTimer
to ensure that timer state is correctly moved and preserved when the UI tree reshuffles during orientation changes or window resizes.
UI Enhancement (#75): Replaced the static SolidDynamicAuthButton with a reactive FutureBuilder logic that shows Icons.login or Icons.logout based on actual session status, as well as a dedicated security key manager button.