Add ease property and connect object types#83
Merged
swsnr merged 3 commits intogjsify:mainfrom Oct 19, 2025
Merged
Conversation
swsnr
requested changes
Oct 18, 2025
Collaborator
swsnr
left a comment
There was a problem hiding this comment.
Please remove type information from doc comment, as it's redundant, and check the types against Gnome 49, as we generally do not support anything but the latest Gnome shell version here.
4f3e1d0 to
73f251f
Compare
swsnr
approved these changes
Oct 18, 2025
swsnr
approved these changes
Oct 19, 2025
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated documentation for existing connect object types.
There is also a way to properly types the args of the connectObject function, but I don't know if that is desired since the resulting type errors are non-descriptive.