Conversation
|
Can you rebase feat/presenter with the newest version of alex_stuff? That should get rid of most of the merge conflicts. |
Yeah i will tonight. Probably. Maybe |
…atures to device createinfo
gituser12981u2
force-pushed
the
feat/presenter
branch
from
22ddda4 to
859b2cf
Compare
| image_count > swapchain_support.capabilities.maxImageCount) { | ||
| image_count = swapchain_support.capabilities.maxImageCount; | ||
| } | ||
| render_path_ = can_use_dynamic_rendering |
There was a problem hiding this comment.
Knowing whether the physical device is vk13 or vk12 is helpful beyond just the render pass path. We should abstract this so it can be reused.
There was a problem hiding this comment.
I will do this. I will probably make a small shared struct that is filled in with device info that can be used.
…rent path than linux and windows runtimes
|
About the Apple issue with VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_2_FEATURES and VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_3_FEATURES I talked to you about, you know the thing that was giving me a segfault, well I made a fix in the last commit and, for fun, I checked the non Apple path on my MacBook and it somehow worked. So I guess everything the chain does work and it was some other little problem with the implementation before. I don't know any more. I will just blame MoltenVK. I am making a new commit without the Apple path. |
Also update some CMake files with cmake_format formatter
| std::move(list)), // This may not require a move | ||
| std::memory_order_release); | ||
| // lint from clang tidy does not work on msvc(it works on GCC, at least!), we | ||
| // should look into this more! TODO |
| QUARK_NO_COPY(Swapchain); | ||
| Swapchain(const Swapchain &) = delete; | ||
| Swapchain &operator=(const Swapchain &) = delete; | ||
| Swapchain(Swapchain &&other) noexcept; |
There was a problem hiding this comment.
Fie upon thee for not using macros
2 participants
Keeping the cmake changes in this as makes it easier to do testing,
Added vk12/vk13 switch, I am pretty sure I could've made it a template class with specialisations for each.
So feel free to rebuke me on that. I don't think it matters(?).
Also added the presenter abstraction.