Skip to content

fix(integration): clarify multi-install guidance#2549

Merged
mnriem merged 1 commit into
github:mainfrom
PascalThuet:codex/integration-guidance-messages
May 14, 2026
Merged

fix(integration): clarify multi-install guidance#2549
mnriem merged 1 commit into
github:mainfrom
PascalThuet:codex/integration-guidance-messages

Conversation

@PascalThuet
Copy link
Copy Markdown
Contributor

Summary

Follow-up to #2498 and #2519.

Clarifies specify integration install guidance when the requested integration is already installed or when installing alongside existing integrations requires an explicit unsafe multi-install opt-in.

Changes

  • Replace the already-installed uninstall first suggestion with non-destructive use / upgrade guidance.
  • Make unsafe multi-install guidance distinguish replacement from coexistence:
    • specify integration switch <key> to replace the default integration.
    • specify integration install <key> --force to install alongside existing integrations anyway.
  • Add tests for default and non-default already-installed integrations, plus unsafe multi-install message content.

Notes

This only changes CLI guidance text and tests. It does not change install, switch, or multi-install behavior.

Validation

Local:

  • uv run pytest tests/integrations/test_integration_subcommand.py -v
  • git diff --check origin/main

CI:

  • Full pytest, ruff, and markdownlint coverage runs via GitHub Actions on the PR.

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (describe below)

Used AI assistance to inspect the existing integration install flow, implement the scoped guidance update, add tests, and run local validation. The changes were reviewed before submission.

@PascalThuet PascalThuet force-pushed the codex/integration-guidance-messages branch from 4ad3d1d to 1535f73 Compare May 13, 2026 23:02
@PascalThuet PascalThuet marked this pull request as ready for review May 14, 2026 05:39
@PascalThuet PascalThuet requested a review from mnriem as a code owner May 14, 2026 05:39
@mnriem mnriem requested a review from Copilot May 14, 2026 13:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Clarifies CLI guidance for specify integration install when an integration is already installed or when unsafe multi-install requires an explicit opt-in.

Changes:

  • Updates already-installed messaging to suggest use or upgrade instead of uninstalling.
  • Separates replacement guidance from coexistence guidance for unsafe multi-install errors.
  • Adds/updates integration subcommand tests to cover the new guidance text.
Show a summary per file
File Description
src/specify_cli/__init__.py Refines integration install guidance messages without changing behavior.
tests/integrations/test_integration_subcommand.py Adds assertions for default/non-default already-installed cases and unsafe multi-install guidance.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@mnriem mnriem merged commit c87081a into github:main May 14, 2026
11 checks passed
@mnriem
Copy link
Copy Markdown
Collaborator

mnriem commented May 14, 2026

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants