fix(implement): remove Makefile from C ignore patterns#1558
fix(implement): remove Makefile from C ignore patterns#1558zaheer15351 wants to merge 1 commit intogithub:mainfrom
Conversation
Makefile is typically source-controlled and should not be in .gitignore. Replaced with proper autotools-generated files (autom4te.cache/, config.status). Co-authored-by: Augment Agent <noreply@augmentcode.com>
There was a problem hiding this comment.
Pull request overview
This PR corrects the C language ignore patterns in the implement.md template by removing Makefile from the gitignore list, as Makefiles are typically version-controlled source files in C projects. The change also updates the patterns to include autotools-generated artifacts (autom4te.cache/, config.status) that should be ignored.
Changes:
- Removed
Makefilefrom C ignore patterns (correct - Makefiles should be version-controlled) - Added
autom4te.cache/andconfig.status(autotools-generated files that should be ignored) - Removed
config.logfrom the ignore patterns (appears to be unintentional)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - **Kotlin**: `build/`, `out/`, `.gradle/`, `.idea/`, `*.class`, `*.jar`, `*.iml`, `*.log`, `.env*` | ||
| - **C++**: `build/`, `bin/`, `obj/`, `out/`, `*.o`, `*.so`, `*.a`, `*.exe`, `*.dll`, `.idea/`, `*.log`, `.env*` | ||
| - **C**: `build/`, `bin/`, `obj/`, `out/`, `*.o`, `*.a`, `*.so`, `*.exe`, `Makefile`, `config.log`, `.idea/`, `*.log`, `.env*` | ||
| - **C**: `build/`, `bin/`, `obj/`, `out/`, `*.o`, `*.a`, `*.so`, `*.exe`, `autom4te.cache/`, `config.status`, `.idea/`, `*.log`, `.env*` |
There was a problem hiding this comment.
The removal of config.log from the C ignore patterns appears to be unintentional. This file is generated by autotools' configure script and should typically be ignored in version control, similar to config.status. Consider adding config.log back to the ignore pattern list alongside the new config.status entry.
| - **C**: `build/`, `bin/`, `obj/`, `out/`, `*.o`, `*.a`, `*.so`, `*.exe`, `autom4te.cache/`, `config.status`, `.idea/`, `*.log`, `.env*` | |
| - **C**: `build/`, `bin/`, `obj/`, `out/`, `*.o`, `*.a`, `*.so`, `*.exe`, `autom4te.cache/`, `config.status`, `config.log`, `.idea/`, `*.log`, `.env*` |
1 participant
Makefile is typically source-controlled and should not be in .gitignore. Replaced with proper autotools-generated files (autom4te.cache/, config.status).